Farras Andriawan #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhimashary
reviewed
Sep 19, 2019
client/index.html
Outdated
| axios({ | ||
| method: 'GET', | ||
| url: 'http://localhost:3000/posts/' | ||
| }).then((response)=>{ |
dhimashary
reviewed
Sep 19, 2019
client/index.html
Outdated
| axios({ | ||
| method: 'DELETE', | ||
| url: 'http://localhost:3000/posts/' + post._id, | ||
| }).then(res =>{ |
There was a problem hiding this comment.
catch tetap perlu di handle jika error
dhimashary
reviewed
Sep 19, 2019
client/index.html
Outdated
| <form v-show="showForm" id="article-form"> | ||
| <label>Article title</label><br> | ||
| <input type="text" name="title" id="form-title" v-model="form.title"><br> | ||
| <p>{{form.description}}</p> |
There was a problem hiding this comment.
tidak perlu di tampilkan disini state nya form description etc
dhimashary
reviewed
Sep 19, 2019
client/index.html
Outdated
| createdAt: new Date() | ||
| } | ||
| }).then(()=>{ | ||
| console.log('success') |
There was a problem hiding this comment.
habis selesai submit di handle pesan sukses / errornya && form di reset dan ditutup kembali
dhimashary
reviewed
Sep 19, 2019
client/index.html
Outdated
| app.submitData(); | ||
| }) | ||
| */ | ||
| $('#btn-update-article').click(function(event){ |
There was a problem hiding this comment.
kalo udah pake vue jquery untuk handle event tidak perlu dilakukan lagi
|
diselesaikan lagi ya kalo sudah sehat |
dhimashary
reviewed
Sep 19, 2019
server/controllers/post.js
Outdated
| } | ||
|
|
||
| static delete(req,res){ | ||
| Post.findByIdAndDelete({_id : req.params.id}).then(()=>{ |
There was a problem hiding this comment.
indentasi then catch perlu dirapihin lagi
dhimashary
reviewed
Sep 19, 2019
server/controllers/post.js
Outdated
| post | ||
| }) | ||
| }).catch((error)=>{ | ||
| message : "failed adding post", |
There was a problem hiding this comment.
hasil error gak dikirim balik ke client
dhimashary
reviewed
Sep 19, 2019
server/controllers/post.js
Outdated
| Post.find().then((posts)=>{ | ||
| res.json(posts) | ||
| }).catch((err)=>{ | ||
| console.log(err) |
dhimashary
reviewed
Sep 19, 2019
server/models/post.js
Outdated
| type : String, | ||
| required : true | ||
| }, | ||
| createdAt: Date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CSS